fix(button): add missing href

core-ds · Apr 24, 2020 · 756d84b · 756d84b
1 parent 69624f9
commit 756d84b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/button/src/Component.tsx b/packages/button/src/Component.tsx
@@ -84,7 +84,7 @@ export const Button = React.forwardRef<HTMLAnchorElement & HTMLButtonElement, Bu
 
         if (href) {
             return (
-                <a {...componentProps} {...restProps} ref={ref}>
+                <a {...componentProps} {...restProps} href={href} ref={ref}>
                     {buttonChildren}
                 </a>
             );

diff --git a/packages/button/src/__snapshots__/Component.test.tsx.snap b/packages/button/src/__snapshots__/Component.test.tsx.snap
@@ -76,12 +76,14 @@ Object {
     <div>
       <a
         class="component secondary m iconOnly"
+        href="https://some-url"
       />
     </div>
   </body>,
   "container": <div>
     <a
       class="component secondary m iconOnly"
+      href="https://some-url"
     />
   </div>,
   "debug": [Function],