fix(tooltip): fix bug with controlled state (#759)

core-ds · Jul 23, 2021 · dd0144e · dd0144e
1 parent 187bb0e
commit dd0144e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/tooltip/src/Component.tsx b/packages/tooltip/src/Component.tsx
@@ -152,8 +152,10 @@ export const Tooltip: FC<TooltipProps> = ({
     const contentRef = useRef<RefElement>(null);
     const timer = useRef(0);
 
+    const show = forcedOpen === undefined ? visible : forcedOpen;
+
     const open = () => {
-        if (!visible) {
+        if (!show) {
             setVisible(true);
 
             if (onOpen) {
@@ -163,17 +165,17 @@ export const Tooltip: FC<TooltipProps> = ({
     };
 
     const close = useCallback(() => {
-        if (visible) {
+        if (show) {
             setVisible(false);
 
             if (onClose) {
                 onClose();
             }
         }
-    }, [onClose, visible]);
+    }, [onClose, show]);
 
     const toggle = () => {
-        if (visible) {
+        if (show) {
             close();
         } else {
             open();
@@ -294,8 +296,6 @@ export const Tooltip: FC<TooltipProps> = ({
         }
     };
 
-    const show = forcedOpen === undefined ? visible : forcedOpen;
-
     return (
         <Fragment>
             <div ref={mergeRefs([targetRef, setTarget])} {...getTargetProps()}>