-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gap): added numeric size values #1037
Conversation
🦋 Changeset detectedLatest commit: 5609ef4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
553e162
to
cea51ce
Compare
Pull Request Test Coverage Report for Build 7527918536
💛 - Coveralls |
cea51ce
to
1f95dc6
Compare
Собрана новая демка. |
1f95dc6
to
52ca293
Compare
'6xl': 'size-72', | ||
'7xl': 'size-96', | ||
'8xl': 'size-128', | ||
0: 'size-0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А ноль зачем? Зачем юзать компонент, если отступ не нужен? Непонятно
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ну может надо по условию менять размер c 0 на какой-то
я не знаю
@Oladii
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вот я затевал их именно для кейсов где мы знаем что отступ тут можно настраивать, но он может быть нулевым.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если отступ может быть нулевым, то лучше не рендерить компонент, чем устанавливать у него нулевую ширину.
{gapSize && <Gap size={gapSize} />}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не думаю, что кто-то этим будет пользоваться
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я бы оставил, в том же SDUI может быть удобнее тупо кинуть в компонент значение, чем добавлять еще доп. условие + могут быть проблемы с типами, если у них будет 0, а у нас нет
Собрана новая демка. |
'6xl': 'size-72', | ||
'7xl': 'size-96', | ||
'8xl': 'size-128', | ||
0: 'size-0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я бы оставил, в том же SDUI может быть удобнее тупо кинуть в компонент значение, чем добавлять еще доп. условие + могут быть проблемы с типами, если у них будет 0, а у нас нет
978eb97
to
5609ef4
Compare
Собрана новая демка. |
No description provided.