Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(universal-date-input): refactoring #1041

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Dec 13, 2023

Описание изменений

Бета для тестирования: @alfalab/core-components 44.5.1-beta.2

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: 3f71143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-universal-date-input Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Dec 15, 2023

Bundle size report

Entry point Size (minified)
universal-date-input/shared.js 43.5 (+42.50 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak force-pushed the fix/change_callbacks_name branch 2 times, most recently from 2538a1f to 26e4879 Compare December 18, 2023 04:31
@v-gevak v-gevak changed the title fix(universal-date-input): rename onChange, onComplete refactoruniversal-date-input): refactoring Dec 18, 2023
@v-gevak v-gevak changed the title refactoruniversal-date-input): refactoring refactor(universal-date-input): refactoring Dec 18, 2023
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7813426539

  • -8 of 71 (88.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/universal-date-input/src/components/time-input/Component.tsx 17 18 94.44%
packages/universal-date-input/src/components/date-input/Component.tsx 20 23 86.96%
packages/universal-date-input/src/components/date-range-input/Component.tsx 26 30 86.67%
Totals Coverage Status
Change from base Build 7800768595: 0.03%
Covered Lines: 9281
Relevant Lines: 10168

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit dc51f88 into master Feb 8, 2024
7 checks passed
@v-gevak v-gevak deleted the fix/change_callbacks_name branch February 8, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants