Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select-with-tags): fix definition of content width #1141

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Valeri8888
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: c48267f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-select-with-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 8418928676

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 84.497%

Totals Coverage Status
Change from base Build 8389272253: -0.006%
Covered Lines: 9367
Relevant Lines: 10254

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@vaness11 vaness11 self-requested a review March 25, 2024 15:00
@@ -275,7 +275,6 @@ export const TagList: FC<Partial<FieldProps> & FormControlProps & TagListOwnProp
onChange={onInput}
className={cn(styles.input, {
[styles.focusVisible]: inputFocusVisible,
[styles.block]: inputOnNewLine,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это ведь для чего-то добавили, точно что-то другое не ломается?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я тестировала, вроде ничего не ломает
я не знаю для чего это было добавлено, перенос на новую строку работает так же как и с этим свойством

@SiebenSieben SiebenSieben merged commit 19b291a into master Mar 29, 2024
8 checks passed
@SiebenSieben SiebenSieben deleted the fix/select-with-tags_inner branch March 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants