fix(confirmation): fixed re-rendering of custom screen #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valeri8888
requested review from
reme3d2y,
EGNKupava and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: 1f34cd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 8419009339Details
💛 - Coveralls |
Valeri8888
force-pushed
the
fix/confirmation_render-custom-screen
branch
from
4e5be35
to
1f34cd6
Compare
|
Собрана новая демка. |
SiebenSieben
approved these changes
Mar 29, 2024
reme3d2y
reviewed
Mar 29, 2024
| @@ -113,7 +113,12 @@ export const BaseConfirmation: FC<ConfirmationProps> = ({ | |||
| onFatalErrorOkButtonClick: handleFatalErrorOkButtonClick, | |||
| }; | |||
|
|
|||
| const screensMap = getScreensMap ? getScreensMap(confirmationScreens) : confirmationScreens; | |||
| const customScreen = useMemo( | |||
There was a problem hiding this comment.
Выглядит не очень надежно. Где эту функцию объявляют? Если она не мемоизирована в родителе, не будет ли это вызывать эту же проблему?
reme3d2y
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.