fix(modal-header): use Header's onClose prop #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rinta01
requested review from
reme3d2y,
Valeri8888 and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: 2b7a115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 8830663524Details
💛 - Coveralls |
|
Собрана новая демка. |
reme3d2y
reviewed
Apr 25, 2024
| @@ -41,7 +41,7 @@ export const Header: FC<HeaderProps> = ({ | |||
| sticky={sticky} | |||
| view={view} | |||
| title={title} | |||
| onClose={onClose} | |||
| onClose={restProps.onClose ?? onClose} | |||
There was a problem hiding this comment.
Стоит создать handleClose и в нем вызывать оба этих обработчика
|
нужен сhangesets |
Rinta01
force-pushed
the
fix/modal-header-on-close
branch
from
89a78c9
to
5eec8c2
Compare
|
Собрана новая демка. |
reme3d2y
approved these changes
Apr 25, 2024
Valeri8888
approved these changes
Apr 27, 2024
fulcanellee
approved these changes
Apr 27, 2024
SiebenSieben
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ModalHeader's own onClose prop. If it doesn't exist, use onClose from Modal component
Опишите проблему
Не работает пропса onClose в ModalHeader, вместо нее ВСЕГДА используется onClose из ModalContext.
Ожидаемое поведение
Пропса onClose должна использоваться и иметь приоритет перед onClose из ModalContext