Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit attributes for supporting objects #37

Closed
drewejohnson opened this issue Oct 19, 2017 · 1 comment
Closed

Explicit attributes for supporting objects #37

drewejohnson opened this issue Oct 19, 2017 · 1 comment
Assignees
@drewejohnson
Labels
pythonicness

Comments

@drewejohnson
Copy link
Collaborator

Currently, supporting objects look for their attributes first in their own metadata, then in the metadata of the metadata of the parent. This poses some introspection ugliness, as it is difficult to determine what attributes are on the object.

Each supporting object should have its attributes explicitly stated and stored. This should improve performance and usability.

Maybe use __slots__ as well?
@drewejohnson drewejohnson self-assigned this Oct 19, 2017
@drewejohnson drewejohnson mentioned this issue Oct 19, 2017
Merged
drewejohnson added a commit that referenced this issue Oct 19, 2017
@drewejohnson
Better support (#40)
2edf9c3 
Closes #37 and #36 by cleaning up supporting object framework

- Removed leading underscore for _Supporting and _Named objects
- Material objects have explicit attributes for burnup, names, adens, and mdens
- Depletion getXY has been depreciated in favor of getValues - time is no longer returned.
@drewejohnson
Copy link
Collaborator Author

Closed with #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewejohnson drewejohnson

Labels
pythonicness
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewejohnson