-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discussion of and CoAP Options for CRI use in CoAP #81
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c43d462
Add discussion of and CoAP Options for CRI use in CoAP
cabo 575e905
More realistic size limits for Proxy-Scheme-Number
cabo 35856e0
Add a Section 8.1
cabo 32d7ee3
Clarify uri-host processing
cabo 6c2b0dd
Use conventional BCP reference for BCP26
cabo aa3a87a
-14: Publish snapshot from CoAP integration branch (PR #81)
cabo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "MUST NOT be used with Uri-Host and Proxy-Scheme" (maybe "it's an error", maybe "one must be ignored").
Maybe "MUST either not have path and query components (in which case Uri-Path and Uri-Query are allowed and just appended semantically), or not occur with those together in a message".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or go full-base, and allow also that there's only the scheme present (at which point Proxy-Scheme-Number becomes somewhat redundant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation here (because the comments above may sound more convinced of myself as it may sound):
In the URI mind set, the difference between sending a request directly and sending it through the proxy is:
(and personally I've always discouraged Proxy-Uri)
If someone wants to do the same trick in the CRI mindset, they can either
Not great, but also somewhat weird to make this more complicated. A Proxy-CRI that may be just scheme and authority would solve this. (As would having a dedicated CRI-SchemeAndAuthority option or a Cri-Host option that is to be combined with Proxy-SchemeNumber).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples:
Request in CoAP-over-TCP to a CoAP resource on a same-host proxcy as described in transport-indication:
Request through a proxy (any transport going forward to UDP literal):
Request through a proxy (any transport going forward to host name):
OSCORE splitting of the Proxy-... options, when hitting Proxy-Cri <<0, "example", "com", ["foo", "bar"]>>
(which this document will probably need to describe to follow the recommendation of OSCORE)