Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECDIR review #18

Merged
merged 19 commits into from Nov 29, 2023
Merged

SECDIR review #18

merged 19 commits into from Nov 29, 2023

Conversation

marco-tiloca-sics
Copy link
Collaborator

This PR addresses the SECDIR review archived at https://mailarchive.ietf.org/arch/msg/secdir/6xBm7c_0kCzNtV16DM9vXuV3RF4/

cabo
cabo requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@cabo cabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the changes that already were in 15-17 are the same.

Unaddressed:
"sum of the MACs" -> sum of the strengths...
(really: combining the strengths, because separate MACs can be attacked separately in general)

draft-ietf-core-oscore-edhoc.md Outdated Show resolved Hide resolved
@marco-tiloca-sics
Copy link
Collaborator Author

Assuming the changes that already were in 15-17 are the same.

Unaddressed: "sum of the MACs" -> sum of the strengths... (really: combining the strengths, because separate MACs can be attacked separately in general)

Now changed in 71c456f

@marco-tiloca-sics
Copy link
Collaborator Author

Assuming the changes that already were in 15-17 are the same.

Unaddressed: "sum of the MACs" -> sum of the strengths... (really: combining the strengths, because separate MACs can be attacked separately in general)

Now further addressed in e859cac

cabo
cabo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@cabo cabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my concerns!

I have one more editorial proposal (see two suggestions below).

draft-ietf-core-oscore-edhoc.md Outdated Show resolved Hide resolved
draft-ietf-core-oscore-edhoc.md Outdated Show resolved Hide resolved
marco-tiloca-sics and others added 2 commits November 22, 2023 09:43
@marco-tiloca-sics @cabo
Update draft-ietf-core-oscore-edhoc.md
0ab26e2 
Co-authored-by: cabo <cabo@tzi.org>
@marco-tiloca-sics @cabo
Update draft-ietf-core-oscore-edhoc.md
2cfa71c 
Co-authored-by: cabo <cabo@tzi.org>
rikard-sics
rikard-sics approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@rikard-sics rikard-sics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gselander
Copy link
Collaborator

Hearing no objection I now merge this.

@gselander gselander merged commit 8d0d76b into main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabo cabo cabo approved these changes

@rikard-sics rikard-sics rikard-sics approved these changes

@gselander gselander Awaiting requested review from gselander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marco-tiloca-sics @gselander @cabo @rikard-sics