Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the endpoint name is a Unicode string #207

Merged
merged 1 commit into from Mar 11, 2019

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Mar 10, 2019

Contributes-To: #190


WIP, will continue there tomorrow (checking whether any other place in the document needs adaption, whether there's any place where to reiterate RFC6690's "is not expected to validate UTF-8 encoding (but is not prohibited from doing so) and doesn't need to perform any UTF-8 normalization", and whether RD-DNS-SD still uses ep and d as it did where the 63 byte limit came from.

Copy link

@petervanderstok petervanderstok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any conflict with rd-dns-sd, a reference from rd-dns-sd to the RD draft looks appropriate.

@chrysn
Copy link
Member Author

chrysn commented Mar 11, 2019

It seems no further changes are needed – when ep gets encoded it is passed into Link Format which is already Unicode; lookup filtering also draws from there; those references also pull in the no-need-to-decode parts (and when it comes to accepting endpoint names, that's a policy issue anyway).

RD-DNS-SD still uses ep and d during DNS entry synthesis, so the 63 byte limit stays.

@chrysn chrysn merged commit d07dde4 into master Mar 11, 2019
chrysn pushed a commit that referenced this pull request Mar 11, 2019
@chrysn chrysn deleted the endpoint-name-utf8 branch March 11, 2019 09:14
@petervanderstok
Copy link

petervanderstok commented Mar 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants