[BUILD] Cleanup phpstan errors

core23 · Mar 20, 2019 · 3402fe2 · 3402fe2
1 parent fc38fb0
commit 3402fe2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -3,14 +3,13 @@ parameters:
         - vendor-bin/test/vendor/autoload.php
 
     includes:
+        - vendor-bin/phpstan/vendor/jangregor/phpstan-prophecy/src/extension.neon
+        - vendor-bin/phpstan/vendor/localheinz/phpstan-rules/rules.neon
         - vendor-bin/phpstan/vendor/phpstan/phpstan-deprecation-rules/rules.neon
         - vendor-bin/phpstan/vendor/phpstan/phpstan-phpunit/extension.neon
         - vendor-bin/phpstan/vendor/phpstan/phpstan-phpunit/rules.neon
         - vendor-bin/phpstan/vendor/phpstan/phpstan-strict-rules/rules.neon
 
     ignoreErrors:
-        # PHPUnit
-        - '#Parameter \#1 \$formMapper of method Core23\\FacebookBundle\\Block\\Service\\PageFeedBlockService::buildEditForm\(\) expects Sonata\\AdminBundle\\Form\\FormMapper, PHPUnit\\Framework\\MockObject\\MockObject given.#'
-
         # Symfony DI
         - '#Cannot call method scalarNode\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null.#'
diff --git a/tests/Block/Service/PageFeedBlockServiceTest.php b/tests/Block/Service/PageFeedBlockServiceTest.php
@@ -17,6 +17,7 @@
 use Facebook\FacebookApp;
 use Facebook\FacebookResponse;
 use Facebook\GraphNodes\GraphEdge;
+use PHPUnit\Framework\MockObject\MockObject;
 use Sonata\AdminBundle\Form\FormMapper;
 use Sonata\BlockBundle\Block\BlockContext;
 use Sonata\BlockBundle\Model\Block;
@@ -111,6 +112,7 @@ public function testBuildEditForm(): void
 
         $block = new Block();
 
+        /** @var MockObject&FormMapper $formMapper */
         $formMapper = $this->createMock(FormMapper::class);
         $formMapper->expects($this->once())->method('add');
 

diff --git a/vendor-bin/phpstan/composer.json b/vendor-bin/phpstan/composer.json
@@ -1,5 +1,7 @@
 {
     "require": {
+        "jangregor/phpstan-prophecy": "^0.3",
+        "localheinz/phpstan-rules": "^0.7",
         "phpstan/phpstan": "^0.11",
         "phpstan/phpstan-phpunit": "^0.11",
         "phpstan/phpstan-strict-rules": "^0.11"