Skip to content

Commit

Permalink
mainboard/asus/m2n-e|msi/ms9282: Clean up FIDVID mistakes
Browse files Browse the repository at this point in the history
These two mainboards contained trivial mistakes related
to FIDVID that broke build when FIDVID was enabled.

Change-Id: Ie7bec77f26ec37eada21308984db4a9fd7a1866f
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: http://review.coreboot.org/12226
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
  • Loading branch information
madscientist159 authored and rminnich committed Oct 30, 2015
1 parent 5669994 commit 2caf3cb
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
10 changes: 9 additions & 1 deletion src/mainboard/asus/m2n-e/romstage.c
Expand Up @@ -65,9 +65,17 @@ static inline int spd_read_byte(unsigned int device, unsigned int address)
#include <southbridge/nvidia/mcp55/early_setup_ss.h>
#include "southbridge/nvidia/mcp55/early_setup_car.c"
#include "cpu/amd/model_fxx/init_cpus.c"
#include "cpu/amd/model_fxx/fidvid.c"
#include "northbridge/amd/amdk8/early_ht.c"

/* FIXME
* Dummy method to allow build
* Determine if this board / CPU should support
* FID/VID and implement proper support if so
*/
#if IS_ENABLED(CONFIG_SET_FIDVID)
void init_fidvid_ap(u32 bsp_apicid, u32 apicid) { }
#endif

static void sio_setup(void)
{
u8 byte;
Expand Down
11 changes: 9 additions & 2 deletions src/mainboard/msi/ms9282/romstage.c
Expand Up @@ -81,10 +81,17 @@ static inline int spd_read_byte(unsigned device, unsigned address)

#include "southbridge/nvidia/mcp55/early_setup_car.c"
#include "cpu/amd/model_fxx/init_cpus.c"
// Disabled until it's actually used:
// #include "cpu/amd/model_fxx/fidvid.c"
#include "northbridge/amd/amdk8/early_ht.c"

/* FIXME
* Dummy method to allow build
* Determine if this board / CPU should support
* FID/VID and implement proper support if so
*/
#if IS_ENABLED(CONFIG_SET_FIDVID)
void init_fidvid_ap(u32 bsp_apicid, u32 apicid) { }
#endif

static void sio_setup(void)
{
uint32_t dword;
Expand Down

0 comments on commit 2caf3cb

Please sign in to comment.