Skip to content

Commit

Permalink
commonlib/console/post_code.h: Change post code prefix to POSTCODE
Browse files Browse the repository at this point in the history
The prefix POSTCODE makes it clear that the macro is a post code.
Hence, replace related macros starting with POST to POSTCODE and
also replace every instance the macros are invoked with the new
name.

The files was changed by running the following bash script from the
top level directory.

  sed -i'' '30,${s/#define POST/#define POSTCODE/g;}' \
  src/commonlib/include/commonlib/console/post_codes.h;
  myArray=`grep -e "^#define POSTCODE_" \
  src/commonlib/include/commonlib/console/post_codes.h | \
  grep -v "POST_CODES_H" | tr '\t' ' ' | cut -d ' ' -f 2`;

  for str in ${myArray[@]}; do
    splitstr=`echo $str | cut -d '_' -f2-`
    grep -r POST_$splitstr src | \
    cut -d ':' -f 1 | xargs sed -i'' -e "s/POST_$splitstr/$str/g";
    grep -r "POST_$splitstr" util/cbfstool | \
    cut -d ':' -f 1 | xargs sed -i'' -e "s/POST_$splitstr/$str/g";
  done

Change-Id: I25db79fa15f032c08678f66d86c10c928b7de9b8
Signed-off-by: lilacious <yuchenhe126@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76043
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
  • Loading branch information
Lilacious authored and felixheld committed Jun 23, 2023
1 parent bb4bc77 commit 40cb3fe
Show file tree
Hide file tree
Showing 68 changed files with 234 additions and 234 deletions.
2 changes: 1 addition & 1 deletion src/arch/x86/acpi_s3.c
Expand Up @@ -27,7 +27,7 @@ void __noreturn acpi_resume(void *wake_vec)

timestamp_add_now(TS_ACPI_WAKE_JUMP);

post_code(POST_OS_RESUME);
post_code(POSTCODE_OS_RESUME);
acpi_do_wakeup((uintptr_t)wake_vec);

die("Failed the jump to wakeup vector\n");
Expand Down
6 changes: 3 additions & 3 deletions src/arch/x86/c_start.S
Expand Up @@ -44,7 +44,7 @@ _start:
call SetCodeSelector
#endif

post_code(POST_ENTRY_C_START) /* post 13 */
post_code(POSTCODE_ENTRY_C_START) /* post 13 */

cld

Expand Down Expand Up @@ -80,7 +80,7 @@ _start:
* bss is cleared. Now we call the main routine and
* let it do the rest.
*/
post_code(POST_PRE_HARDWAREMAIN) /* post 6e */
post_code(POSTCODE_PRE_HARDWAREMAIN) /* post 6e */

andl $0xFFFFFFF0, %esp

Expand All @@ -95,7 +95,7 @@ _start:
call main
/* NOTREACHED */
.Lhlt:
post_code(POST_DEAD_CODE) /* post ee */
post_code(POSTCODE_DEAD_CODE) /* post ee */
hlt
jmp .Lhlt

Expand Down
4 changes: 2 additions & 2 deletions src/arch/x86/postcar_loader.c
Expand Up @@ -102,12 +102,12 @@ static void load_postcar_cbfs(struct prog *prog, struct postcar_frame *pcf)
vboot_run_logic();

if (rmodule_stage_load(&rsl))
die_with_post_code(POST_INVALID_ROM,
die_with_post_code(POSTCODE_INVALID_ROM,
"Failed to load after CAR program.\n");

/* Set the stack pointer within parameters of the program loaded. */
if (rsl.params == NULL)
die_with_post_code(POST_INVALID_ROM,
die_with_post_code(POSTCODE_INVALID_ROM,
"No parameters found in after CAR program.\n");

finalize_load(rsl.params, (uintptr_t)pcf->mtrr);
Expand Down
6 changes: 3 additions & 3 deletions src/arch/x86/tables.c
Expand Up @@ -17,7 +17,7 @@ static unsigned long write_pirq_table(unsigned long rom_table_end)
unsigned long high_table_pointer;

#define MAX_PIRQ_TABLE_SIZE (4 * 1024)
post_code(POST_X86_WRITE_PIRQ_TABLE);
post_code(POSTCODE_X86_WRITE_PIRQ_TABLE);

/* This table must be between 0x0f0000 and 0x100000 */
rom_table_end = write_pirq_routing_table(rom_table_end);
Expand Down Expand Up @@ -49,7 +49,7 @@ static unsigned long write_mptable(unsigned long rom_table_end)
unsigned long high_table_pointer;

#define MAX_MP_TABLE_SIZE (4 * 1024)
post_code(POST_X86_WRITE_MPTABLE);
post_code(POSTCODE_X86_WRITE_MPTABLE);

/* The smp table must be in 0-1K, 639K-640K, or 960K-1M */
rom_table_end = write_smp_table(rom_table_end);
Expand Down Expand Up @@ -78,7 +78,7 @@ static unsigned long write_acpi_table(unsigned long rom_table_end)
unsigned long high_table_pointer;
const size_t max_acpi_size = CONFIG_MAX_ACPI_TABLE_SIZE_KB * KiB;

post_code(POST_X86_WRITE_ACPITABLE);
post_code(POSTCODE_X86_WRITE_ACPITABLE);

/* Write ACPI tables to F segment and high tables area */

Expand Down

0 comments on commit 40cb3fe

Please sign in to comment.