mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant

Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_202209`:
* Windows 10
* Ubuntu 20.04
* MX Linux 19.4
* Manjaro 21

No known issues.

https://starlabs.systems/pages/starbook-specification

Signed-off-by: Ben-StarLabs <ben@starlabs.systems>
Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65785
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com>

Documentation/mainboard/index.md

@@ -185,6 +185,7 @@ The boards in this section are not real mainboards, but emulators.
 - [StarLite Mk III](starlabs/lite_glk.md)
 - [StarLite Mk IV](starlabs/lite_glkr.md)
 - [StarBook Mk V](starlabs/starbook_tgl.md)
+- [StarBook Mk VI](starlabs/starbook_adl.md)
 - [Flashing devices](starlabs/common/flashing.md)
 
 ## Supermicro

Documentation/mainboard/starlabs/starbook_adl.md

@@ -0,0 +1,86 @@
+# StarBook Mk V
+
+## Specs
+
+- CPU (full processor specs available at https://ark.intel.com)
+    - Intel i7-1260P (Alder Lake)
+    - Intel i3-1220P (Alder Lake)
+- EC
+    - ITE IT5570E
+    - Backlit keyboard, with standard PS/2 keycodes and SCI hotkeys
+    - Battery
+    - Charger, using AC adapter or USB-C PD
+    - Suspend / resume
+- GPU
+    - Intel® Iris® Xe Graphics
+    - GOP driver is recommended, VBT is provided
+    - eDP 14-inch 1920x1080 LCD
+    - HDMI video
+    - USB-C DisplayPort video
+- Memory
+    - 2 x DDR4 SODIMM
+- Networking
+    - AX210 2230 WiFi / Bluetooth
+- Sound
+    - Realtek ALC269-VB6
+    - Internal speakers
+    - Internal microphone
+    - Combined headphone / microphone 3.5-mm jack
+    - HDMI audio
+    - USB-C DisplayPort audio
+- Storage
+    - M.2 PCIe SSD
+    - RTS5129 MicroSD card reader
+- USB
+    - 1920x1080 CCD camera
+    - USB 3.1 Gen 2 (left)
+    - USB 3.1 Gen 2 Type-A (left)
+    - USB 3.1 Gen 1 Type-A (right)
+    - USB 2.0 Type-A (right)
+
+## Building coreboot
+
+### Preliminaries
+
+Prior to building coreboot the following files are required:
+* Intel Flash Descriptor file (descriptor.bin)
+* Intel Management Engine firmware (me.bin)
+* ITE Embedded Controller firmware (ec.bin)
+
+The files listed below are optional:
+- Splash screen image in Windows 3.1 BMP format (Logo.bmp)
+
+These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo.
+
+### Build
+
+The following commands will build a working image:
+
+```bash
+make distclean
+make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_starbook_adl
+make
+```
+
+## Flashing coreboot
+
+```eval_rst
++---------------------+------------+
+| Type                | Value      |
++=====================+============+
+| Socketed flash      | no         |
++---------------------+------------+
+| Vendor              | Winbond    |
++---------------------+------------+
+| Model               | W25Q256.V  |
++---------------------+------------+
+| Size                | 32 MiB     |
++---------------------+------------+
+| Package             | SOIC-8     |
++---------------------+------------+
+| Internal flashing   | yes        |
++---------------------+------------+
+| External flashing   | yes        |
++---------------------+------------+
+
+Please see [here](../common/flashing.md) for instructions on how to flash with fwupd.

src/mainboard/starlabs/starbook/Kconfig

@@ -55,11 +55,29 @@ config BOARD_STARLABS_STARBOOK_TGL
 	select SPI_FLASH_WINBOND
 	select TPM_MEASURED_BOOT
 
+config BOARD_STARLABS_STARBOOK_ADL
+	select BOARD_ROMSIZE_KB_32768
+	select BOARD_STARLABS_STARBOOK_SERIES
+	select DRIVERS_INTEL_PMC
+	select EC_STARLABS_KBL_LEVELS
+	select EC_STARLABS_MAX_CHARGE
+	select EC_STARLABS_MIRROR_FLAG
+	select EC_STARLABS_NEED_ITE_BIN
+	select MEMORY_MAPPED_TPM
+	select MAINBOARD_HAS_TPM2
+	select SOC_INTEL_ALDERLAKE
+	select SOC_INTEL_ALDERLAKE_PCH_P
+	select SOC_INTEL_ALDERLAKE_S3
+	select SPI_FLASH_WINBOND
+	select TPM_MEASURED_BOOT
+	select PCIEXP_SUPPORT_RESIZABLE_BARS
+
 if BOARD_STARLABS_STARBOOK_SERIES
 
 config CCD_PORT
 	int
 	default 6 if BOARD_STARLABS_LABTOP_CML
+	default 4 if BOARD_STARLABS_STARBOOK_ADL
 	default 3
 
 config CMOS_DEFAULT_FILE
@@ -72,13 +90,13 @@ config DEVICETREE
 	default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb"
 
 config DIMM_SPD_SIZE
-	default 512 if BOARD_STARLABS_LABTOP_KBL
+	default 512
 
 config DRIVER_TPM_SPI_CHIP
 	default 2
 
 config EC_GPE_SCI
-	default 0x6e if BOARD_STARLABS_STARBOOK_TGL
+	default 0x6e if BOARD_STARLABS_STARBOOK_TGL || BOARD_STARLABS_STARBOOK_ADL
 	default 0x50
 
 config EC_STARLABS_ADD_ITE_BIN
@@ -93,6 +111,7 @@ config EC_VARIANT_DIR
 	default "kbl" if !EC_STARLABS_MERLIN && BOARD_STARLABS_LABTOP_KBL
 	default "cml" if !EC_STARLABS_MERLIN && BOARD_STARLABS_LABTOP_CML
 	default "tgl" if !EC_STARLABS_MERLIN && BOARD_STARLABS_STARBOOK_TGL
+	default "adl" if !EC_STARLABS_MERLIN && BOARD_STARLABS_STARBOOK_ADL
 
 config FMDFILE
 	default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/board.fmd"
@@ -109,14 +128,16 @@ config MAINBOARD_FAMILY
 	default "L3" if BOARD_STARLABS_LABTOP_KBL
 	default "L4" if BOARD_STARLABS_LABTOP_CML
 	default "B5" if BOARD_STARLABS_STARBOOK_TGL
+	default "B6-I" if BOARD_STARLABS_STARBOOK_ADL
 
 config MAINBOARD_PART_NUMBER
 	default "LabTop Mk III" if BOARD_STARLABS_LABTOP_KBL
 	default "LabTop Mk IV" if BOARD_STARLABS_LABTOP_CML
 	default "StarBook Mk V" if BOARD_STARLABS_STARBOOK_TGL
+	default "StarBook Mk VI" if BOARD_STARLABS_STARBOOK_ADL
 
 config MAINBOARD_SMBIOS_PRODUCT_NAME
-	default "StarBook" if BOARD_STARLABS_STARBOOK_TGL
+	default "StarBook" if BOARD_STARLABS_STARBOOK_TGL || BOARD_STARLABS_STARBOOK_ADL
 	default "LabTop"
 
 config ME_BIN_PATH
@@ -127,15 +148,23 @@ config EDK2_BOOTSPLASH_FILE
 	string
 	default "3rdparty/blobs/mainboard/starlabs/Logo.bmp"
 
+config PCIEXP_DEFAULT_MAX_RESIZABLE_BAR_BITS
+	default 32
+
+config SOC_INTEL_CSE_SEND_EOP_EARLY
+	default n if BOARD_STARLABS_STARBOOK_ADL
+
 config UART_FOR_CONSOLE
+	default 0 if BOARD_STARLABS_STARBOOK_ADL
 	default 2
 
 config USE_PM_ACPI_TIMER
-	default n if BOARD_STARLABS_STARBOOK_TGL
+	default n if BOARD_STARLABS_STARBOOK_TGL || BOARD_STARLABS_STARBOOK_ADL
 
 config VARIANT_DIR
 	default "kbl" if BOARD_STARLABS_LABTOP_KBL
 	default "cml" if BOARD_STARLABS_LABTOP_CML
 	default "tgl" if BOARD_STARLABS_STARBOOK_TGL
+	default "adl" if BOARD_STARLABS_STARBOOK_ADL
 
 endif

src/mainboard/starlabs/starbook/Kconfig.name

@@ -8,3 +8,6 @@ config BOARD_STARLABS_LABTOP_CML
 
 config BOARD_STARLABS_STARBOOK_TGL
 	bool "Star Labs StarBook Mk V (i3-1115G4 and i7-1165G7)"
+
+config BOARD_STARLABS_STARBOOK_ADL
+	bool "Star Labs StarBook Mk VI (i3-1220P and i7-1260P)"

src/mainboard/starlabs/starbook/dsdt.asl

@@ -7,7 +7,7 @@ DefinitionBlock(
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
-	0x20110725
+	0x20220930
 )
 {
 	#include <acpi/dsdt_top.asl>
@@ -30,6 +30,9 @@ DefinitionBlock(
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/tigerlake/acpi/southbridge.asl>
 		#include <soc/intel/tigerlake/acpi/tcss.asl>
+#elif CONFIG(SOC_INTEL_ALDERLAKE)
+		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
+		#include <soc/intel/alderlake/acpi/southbridge.asl>
 #endif
 
 		/* PS/2 Keyboard */

src/mainboard/starlabs/starbook/variants/adl/Makefile.inc

@@ -0,0 +1,9 @@
+## SPDX-License-Identifier: GPL-2.0-only
+
+bootblock-y += gpio.c
+
+romstage-y += romstage.c
+
+ramstage-y += devtree.c
+ramstage-y += gpio.c
+ramstage-y += hda_verb.c

src/mainboard/starlabs/starbook/variants/adl/board.fmd

@@ -0,0 +1,14 @@
+FLASH	0x2000000 {
+	SI_ALL	0x1000000 {
+		SI_DESC			0x1000
+		SI_ME
+	}
+	SI_BIOS 0x1000000 {
+		EC@0x0			0x20000
+		RW_MRC_CACHE@0x20000	0x10000
+		SMMSTORE@0x30000	0x40000
+		CONSOLE@0x70000		0x20000
+		FMAP@0x90000		0x1000
+		COREBOOT(CBFS)
+	}
+}