Skip to content

Commit

Permalink
src/arch/x86/acpi.c: Use correct host address width in DMAR ACPI table
Browse files Browse the repository at this point in the history
The previous implementation assumed the CPU physical address size to
be 40 which is not true of all platforms. Use an existing function to
obtain the correct CPU physical address to report in the DMAR ACPI
table.

Change-Id: Ia79e9dadecc3f5f6a86ce3789b213222bef482b3
Signed-off-by: Jacob Laska <jlaska91@gmail.com>
Reviewed-on: https://review.coreboot.org/14102
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
  • Loading branch information
jacoblaska authored and Martin Roth committed Mar 18, 2016
1 parent 331ac1b commit f3f654d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/arch/x86/acpi.c
Expand Up @@ -411,7 +411,7 @@ void acpi_create_dmar(acpi_dmar_t *dmar, enum dmar_flags flags,
header->length = sizeof(acpi_dmar_t);
header->revision = 1;

dmar->host_address_width = 40 - 1; /* FIXME: == MTRR size? */
dmar->host_address_width = cpu_phys_address_size() - 1;
dmar->flags = flags;

current = acpi_fill_dmar(current);
Expand Down

0 comments on commit f3f654d

Please sign in to comment.