-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range plugin never calls free
#182
Comments
FWIW I noticed this when building the |
at a quick look I think the fix is to check for |
I think this is the same issue as #148 but that was on the previous implementation of the plugin. Your solution sounds good for the release messages in any case. |
I think this is the incorrect fix. The correct fix is to have a (1) Periodically when it's time for the next cleaning to occur. (This can be calculated) I have a simplistic implementation in https://github.com/purpleidea/mgmt/ for this now. HTH |
I was reviewing the code in the dhcp range plugin which is found here:
https://github.com/coredhcp/coredhcp/tree/master/plugins/range
I noticed that it never calls the
Free()
method on the allocator.In effect, this is a serious "lease leak" since any expired lease will never get deallocated. This means you will eventually get lease exhaustion which is a kind of denial of service issue.
Cheers!
The text was updated successfully, but these errors were encountered: