New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modules for RFC8925 and RFC2563 #170
Conversation
ab78e10
to
1bce7ad
Compare
8d51b3e
to
c45bda2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is very nice; sorry for missing it the first time you posted it
There are a few questions and follow-ups inline and a couple changes I'd like to see, but otherwise this is a nice approach
Thank you for your thorough code review! This is excellent timing - right now I'm at APRICOT 2024 in Bangkok and I'm using this code for the IPv6-only SSID in the conference network. I'll go through all your notes tomorrow, and should be able to deploy the updated code in advance of the conference starting on Tuesday. I added the MAC address logging to be able to report on how many clients support these DHCP options. |
e12c5ab
to
e890fe2
Compare
I have pushed the code which would be used if the latest version of insomniacslk/dhcp#524 is accepted (and tested it in a go workspace) I have left AutoConfigure as it is, pending feedback on insomniacslk/dhcp#525 |
e890fe2
to
bbe881c
Compare
This is good to merge as far as I'm concerned, as soon as the upstream discussions are resolved |
bbe881c
to
7eed5f7
Compare
control of link-local autoconfigure (RFC2563) Signed-off-by: Brian Candler <b.candler@pobox.com>
7eed5f7
to
eb3cff2
Compare
The changes to insomniacslk/dhcp have been accepted, and I've done Note: I did a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 46.58% 47.11% +0.52%
==========================================
Files 16 18 +2
Lines 1157 1212 +55
==========================================
+ Hits 539 571 +32
- Misses 568 591 +23
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for your contribution! |
FYI, a few stats from the IPv6-only SSID at APRICOT 2024, using coredhcp + radvd + jool:
It appears that RFC8925 support is widespread, but RFC2563 is non-existent. |
These modules support DHCPv4 responses for IPv6-only or IPv6-mostly networks.
In particular: macOS / iOS / Android will configure their built-in CLAT if you provide the RFC8925 DHCPv4 response and advertise a RFC8781 NAT64 prefix in your Router Advertisements.