Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker step from release process #4858

Closed
miekg opened this issue Sep 13, 2021 · 1 comment
Closed

Remove docker step from release process #4858

miekg opened this issue Sep 13, 2021 · 1 comment
Labels
enhancement

Comments

@miekg
Copy link
Member

miekg commented Sep 13, 2021

4 of the 5 release failures had docker as it's root cause.

This is issue is to track the complete removal of docker code from the binary release process; it best to spun this off to a new Makefile.docker that contains the docker stuff. This should download from github the latest released binaries in put them in a docker image. This also allows for better retrying.

This needs:

  • update to .dreck.yaml for a /docker command that calls into the Makefile.docker
  • Removal/move of docker stuff from Makefile.release
  • Update to coredns/release to add 'docker' script - although I hope this can be a few lines and call into Makefile.docker
  • Update to the release process docs
miekg added a commit that referenced this issue Sep 13, 2021
@miekg
Spun out docker
f048029 
Remove docker from Makefile.release so we can actually release.
Unify the mips stuff, now that docker is gone.
Update the docs to reflect this.

See #4858

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg mentioned this issue Sep 13, 2021
Merged
miekg added a commit to coredns/release that referenced this issue Sep 13, 2021
@miekg
Remove docker targets from scripts
c0adf78 
This updates the script to not mention docker - still needs
to be provisioned on the build server.

See coredns/coredns#4858

Signed-off-by: Miek Gieben <miek@miek.nl>
This was referenced Sep 13, 2021
Merged
Closed
miekg added a commit that referenced this issue Sep 13, 2021
@miekg
Spun out docker (#4859)
df92e8a 
* Spun out docker

Remove docker from Makefile.release so we can actually release.
Unify the mips stuff, now that docker is gone.
Update the docs to reflect this.

See #4858

Signed-off-by: Miek Gieben <miek@miek.nl>

* Update test as well

Signed-off-by: Miek Gieben <miek@miek.nl>
miekg added a commit that referenced this issue Sep 14, 2021
@miekg
add docker in Makefile.docker
febd12c 
This adds the (older) docker stuff back in a new Makefile.docker. Add
.dreck alias to be able to release the docker stuff via a github issue.

See #4858

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg mentioned this issue Sep 14, 2021
Merged
miekg added a commit to coredns/release that referenced this issue Sep 14, 2021
@miekg
Add docker release script
686dedf 
See coredns/coredns#4858

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg mentioned this issue Sep 14, 2021
Merged
miekg added a commit that referenced this issue Sep 14, 2021
@miekg
add docker in Makefile.docker (#4864)
f48cce6 
This adds the (older) docker stuff back in a new Makefile.docker. Add
.dreck alias to be able to release the docker stuff via a github issue.

See #4858

Signed-off-by: Miek Gieben <miek@miek.nl>
@chrisohaver
Copy link
Member

Closing. I think all bullets are complete.

jinglina pushed a commit to jinglina/coredns that referenced this issue Dec 23, 2021
@miekg @jinglina
Spun out docker (coredns#4859)
9a271fa 
* Spun out docker

Remove docker from Makefile.release so we can actually release.
Unify the mips stuff, now that docker is gone.
Update the docs to reflect this.

See coredns#4858

Signed-off-by: Miek Gieben <miek@miek.nl>

* Update test as well

Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: jinglinax@163.com <jinglinax@163.com>
jinglina pushed a commit to jinglina/coredns that referenced this issue Dec 23, 2021
@miekg @jinglina
add docker in Makefile.docker (coredns#4864)
8728921 
This adds the (older) docker stuff back in a new Makefile.docker. Add
.dreck alias to be able to release the docker stuff via a github issue.

See coredns#4858

Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: jinglinax@163.com <jinglinax@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miekg @chrisohaver