return an error for multiple use of some plugins #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code would be shorter/cleaner with |
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 53.05% 53.02% -0.04%
==========================================
Files 185 185
Lines 9309 9466 +157
==========================================
+ Hits 4939 5019 +80
- Misses 3990 4068 +78
+ Partials 380 379 -1
Continue to review full report at Codecov.
|
miekg
changed the title
|
This now adds it for:
and changes it slightly in
|
Return plugin.ErrOnce when a plugin that doesn't support it, is called mutliple times. This now adds it for: cache, dnssec, errors, forward, hosts, nsid. And changes it slightly in kubernetes, pprof, reload, root.
|
merging as is, holler when stuff breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return plugin.ErrOnce when a plugin that doesn't support it, is called
mutliple times.
WIP: because I need to go through all of the plugins