plugin/forward: various cleanup

[miekg]

Fix documentation and remove the unused From method.

Signed-off-by: Miek Gieben miek@miek.nl

[corbot]

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked johnbelamaric (via plugin/forward/OWNERS) for a review.

[codecov-io]

Codecov Report

Merging #1949 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
+ Coverage   54.43%   54.44%   +<.01%     
==========================================
  Files         197      197              
  Lines        9574     9572       -2     
==========================================
- Hits         5212     5211       -1     
+ Misses       3957     3956       -1     
  Partials      405      405

Impacted Files	Coverage Δ
plugin/forward/forward.go	56.47% <0%> (+0.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c2871...2891c7c. Read the comment docs.

[miekg]

/merge

[rdrozhdzh]

@miekg, the method Forward.From() was requested in #1762, and added in #1766. It may be still needed.
@fturib, @ekleiner, could you confirm?

[miekg]

Ah yes, damn, I remember. Something, something that needed this. If there are no in-tree users of exported functions this is not sustainable (and there is no backwards compatibility guarantee)

[fturib]

@rdrozhdzh : thank you for reminding these requests.
After check in our ATEPMonitor plugin, I think we are not using it anymore.

@miekg : what do you mean by "in-tree users of exported functions" ? I mean, how should we code the functions we need to be public for external plugins such a way they will not be deleted in refactoring ?

[miekg]

[ Quoting <notifications@github.com> in "Re: [coredns/coredns] plugin/forwar..." ]

@rdrozhdzh : thank you for reminding these requests. After check in our ATEPMonitor plugin, I think we are not using it anymore. @miekg : what do you mean by "in-tree users of exported functions" ? I mean, how should we code the functions we need to be public for external plugins such a way they will not be deleted in refactoring ?

We can't be expected to maintain some sort of backwards compatibility for (probably, accidentally) export functions *in* plugins. And now you tell me you actually don't need (nor use) those functions anyway, which just proofs my point. /Miek

…

-- Miek Gieben