Make presubmit actually fail the build #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code wasn't properly acted upon in the makefile. Make filename-hyphen actually return an non-zero exit code. Signed-off-by: Miek Gieben <miek@miek.nl>
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked stp-ip (via If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository. The bot understands the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 200 200
Lines 9725 9725
=======================================
Hits 5339 5339
Misses 3976 3976
Partials 410 410Continue to review full report at Codecov.
|
mdgreenfield
pushed a commit
to DataDog/coredns
that referenced
this pull request
Mar 4, 2019
The exit code wasn't properly acted upon in the makefile. Make filename-hyphen actually return an non-zero exit code. Signed-off-by: Miek Gieben <miek@miek.nl>
Jason-ZW
pushed a commit
to rancher/coredns
that referenced
this pull request
Apr 17, 2019
The exit code wasn't properly acted upon in the makefile. Make filename-hyphen actually return an non-zero exit code. Signed-off-by: Miek Gieben <miek@miek.nl>
dna2github
pushed a commit
to dna2fork/coredns
that referenced
this pull request
Jul 19, 2019
The exit code wasn't properly acted upon in the makefile. Make filename-hyphen actually return an non-zero exit code. Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code wasn't properly acted upon in the makefile.
Make filename-hyphen actually return an non-zero exit code.
Signed-off-by: Miek Gieben miek@miek.nl