Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mis-spelling in object.go #3134

Merged
merged 1 commit into from Aug 16, 2019
Merged

fix mis-spelling in object.go #3134

merged 1 commit into from Aug 16, 2019

Conversation

AllenZMC
Copy link
Contributor

1. Why is this pull request needed and what does it do?

Make the comment more readable

@corbot
Copy link

corbot bot commented Aug 16, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked johnbelamaric (via plugin/kubernetes/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@corbot corbot bot requested a review from johnbelamaric August 16, 2019 13:22
@chrisohaver chrisohaver merged commit d36ca09 into coredns:master Aug 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #3134 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
+ Coverage   55.48%   55.51%   +0.02%     
==========================================
  Files         207      207              
  Lines       10336    10336              
==========================================
+ Hits         5735     5738       +3     
+ Misses       4186     4183       -3     
  Partials      415      415
Impacted Files Coverage Δ
plugin/forward/connect.go 85.91% <0%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe60f10...04bb054. Read the comment docs.

@AllenZMC AllenZMC deleted the patch-3 branch August 16, 2019 14:21
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants