Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/clouddns: tiny fixes for the README #3140

Merged
merged 2 commits into from Aug 18, 2019
Merged

plugin/clouddns: tiny fixes for the README #3140

merged 2 commits into from Aug 18, 2019

Conversation

miekg
Copy link
Member

@miekg miekg commented Aug 18, 2019

Did a post-merge review. Fix a few typos.

Did a post-merge review. Fix a few typos.

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from yongtang August 18, 2019 08:10
@corbot
Copy link

corbot bot commented Aug 18, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked yongtang (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

coredns -> CoreDNS
clouddns -> Cloud DNS
and italics then the plugin's name are mentioned.

Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #3140 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3140      +/-   ##
==========================================
+ Coverage   55.73%   55.76%   +0.02%     
==========================================
  Files         210      210              
  Lines       10516    10516              
==========================================
+ Hits         5861     5864       +3     
+ Misses       4229     4227       -2     
+ Partials      426      425       -1
Impacted Files Coverage Δ
plugin/route53/route53.go 86.61% <0%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53d822...3556429. Read the comment docs.

@miekg miekg merged commit bbc78ab into master Aug 18, 2019
@corbot corbot bot deleted the cl2 branch August 18, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants