Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker buildx for release image #4779

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

saschagrunert
Copy link
Contributor

1. Why is this pull request needed and what does it do?

This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.

2. Which issues (if any) are related?

Refers to kubernetes/kubernetes#104085

3. Which documentation changes (if any) need to be made?

None

4. Does this introduce a backward incompatible change or deprecation?

Fixed architecture within manifest for non amd64 images.

This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@dims
Copy link

dims commented Aug 4, 2021

cc @johnbelamaric

@codecov-commenter
Copy link

Codecov Report

Merging #4779 (b5d5a83) into master (93c57b6) will decrease coverage by 0.33%.
The diff coverage is 61.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
- Coverage   55.70%   55.36%   -0.34%     
==========================================
  Files         224      232       +8     
  Lines       10016    14367    +4351     
==========================================
+ Hits         5579     7954    +2375     
- Misses       3978     5918    +1940     
- Partials      459      495      +36     
Impacted Files Coverage Δ
core/dnsserver/address.go 100.00% <ø> (ø)
core/dnsserver/config.go 0.00% <ø> (ø)
core/dnsserver/onstartup.go 0.00% <0.00%> (ø)
core/dnsserver/server.go 34.69% <0.00%> (+8.37%) ⬆️
plugin/auto/auto.go 0.00% <0.00%> (ø)
plugin/auto/zone.go 78.94% <ø> (+0.68%) ⬆️
plugin/backend_lookup.go 0.00% <0.00%> (ø)
plugin/bind/bind.go 50.00% <0.00%> (-50.00%) ⬇️
plugin/etcd/etcd.go 0.00% <ø> (ø)
plugin/etcd/setup.go 1.14% <0.00%> (-0.26%) ⬇️
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4758070...b5d5a83. Read the comment docs.

@johnbelamaric
Copy link
Member

/approve
/merge

@chrisohaver @miekg
@saschagrunert I assume this means our published manifests are wrong today?

@johnbelamaric johnbelamaric merged commit 1518f26 into coredns:master Aug 4, 2021
@dims
Copy link

dims commented Aug 4, 2021

@johnbelamaric unfortunately some of the arch(es) are wrong, kubernetes/kubernetes#104085 has some details.

@saschagrunert saschagrunert deleted the buildx branch August 4, 2021 18:04
@saschagrunert
Copy link
Contributor Author

Yes the issue should mainly affect the manifests for the non amd64 bit images, while the binaries within the images are correct.

This was referenced Sep 10, 2021
@miekg
Copy link
Member

miekg commented Sep 22, 2021

fyi: this change has been reverted because it broke the docker build.

if something like this is still needed, it cannot assume binfmt kernel module is loaded and it should not run a privileged docker container

jinglina pushed a commit to jinglina/coredns that referenced this pull request Dec 23, 2021
This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: jinglinax@163.com <jinglinax@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants