-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker buildx for release image #4779
Conversation
This allows to choose the correct architecture in the image manifest, which defaulted to the host system before applying this patch. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #4779 +/- ##
==========================================
- Coverage 55.70% 55.36% -0.34%
==========================================
Files 224 232 +8
Lines 10016 14367 +4351
==========================================
+ Hits 5579 7954 +2375
- Misses 3978 5918 +1940
- Partials 459 495 +36
Continue to review full report at Codecov.
|
/approve @chrisohaver @miekg |
@johnbelamaric unfortunately some of the arch(es) are wrong, kubernetes/kubernetes#104085 has some details. |
Yes the issue should mainly affect the manifests for the non amd64 bit images, while the binaries within the images are correct. |
fyi: this change has been reverted because it broke the docker build. if something like this is still needed, it cannot assume binfmt kernel module is loaded and it should not run a privileged docker container |
This allows to choose the correct architecture in the image manifest, which defaulted to the host system before applying this patch. Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Signed-off-by: jinglinax@163.com <jinglinax@163.com>
1. Why is this pull request needed and what does it do?
This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.
2. Which issues (if any) are related?
Refers to kubernetes/kubernetes#104085
3. Which documentation changes (if any) need to be made?
None
4. Does this introduce a backward incompatible change or deprecation?
Fixed architecture within manifest for non
amd64
images.