1.8.5 release note for cache miss metric deprecation #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisohaver
requested review from
bradbeam,
dilyevsky,
greenpau,
Isolus,
johnbelamaric,
miekg,
pmoroney,
rajansandeep,
stp-ip,
SuperQ and
yongtang
as code owners
miekg
reviewed
Sep 10, 2021
Co-authored-by: Miek Gieben <miek@miek.nl>
Codecov Report
@@ Coverage Diff @@
## master #4857 +/- ##
==========================================
- Coverage 55.70% 55.59% -0.11%
==========================================
Files 224 232 +8
Lines 10016 14387 +4371
==========================================
+ Hits 5579 7999 +2420
- Misses 3978 5891 +1913
- Partials 459 497 +38
Continue to review full report at Codecov.
|
yongtang
approved these changes
Sep 10, 2021
|
LGTM as the review comment has been addressed. |
jinglina
pushed a commit
to jinglina/coredns
that referenced
this pull request
Dec 23, 2021
* Note cache miss metric deprecation * Update notes/coredns-1.8.5.md Co-authored-by: Miek Gieben <miek@miek.nl> Co-authored-by: Miek Gieben <miek@miek.nl> Signed-off-by: jinglinax@163.com <jinglinax@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Add note for cache miss metric deprecation in 1.8.5 release.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?