Makefile.release: Force http 1.1 #4877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
chrisohaver
requested review from
bradbeam,
dilyevsky,
greenpau,
Isolus,
johnbelamaric,
miekg,
pmoroney,
rajansandeep,
stp-ip,
SuperQ and
yongtang
as code owners
|
I suppose we can consider this if the token troubleshooting doesn't pan out. |
Codecov Report
@@ Coverage Diff @@
## master #4877 +/- ##
==========================================
- Coverage 55.70% 55.65% -0.05%
==========================================
Files 224 232 +8
Lines 10016 14399 +4383
==========================================
+ Hits 5579 8014 +2435
- Misses 3978 5888 +1910
- Partials 459 497 +38
Continue to review full report at Codecov.
|
|
Not needed, see release issue comments
/close
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris O'Haver cohaver@infoblox.com
1. Why is this pull request needed and what does it do?
Perhaps not a great idea to do this long term, but for now force http 1.1 for curl ... taking a stab in the dark at sidestepping the recent http2 failures seen in #4853.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?