plugin/kubernetes: fix reload panic #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
chrisohaver
requested review from
bradbeam,
johnbelamaric,
miekg,
rajansandeep,
yongtang and
zouyee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4881 +/- ##
==========================================
- Coverage 55.70% 55.66% -0.05%
==========================================
Files 224 232 +8
Lines 10016 14398 +4382
==========================================
+ Hits 5579 8014 +2435
- Misses 3978 5887 +1909
- Partials 459 497 +38
Continue to review full report at Codecov.
|
miekg
reviewed
Sep 22, 2021
| @@ -31,7 +31,6 @@ var log = clog.NewWithPlugin(pluginName) | |||
| func init() { plugin.Register(pluginName, setup) } | |||
|
|
|||
| func setup(c *caddy.Controller) error { | |||
| klog.InitFlags(nil) | |||
There was a problem hiding this comment.
LOL, (not!). How can we prevent this being added back in again?
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
I opened an issue to add a reload test to coredns/ci. |
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Added ... without this fix ... with this fix ... |
jinglina
pushed a commit
to jinglina/coredns
that referenced
this pull request
Dec 23, 2021
* fix reload panic Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * add comment Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * o import ordering Signed-off-by: Chris O'Haver <cohaver@infoblox.com> Signed-off-by: jinglinax@163.com <jinglinax@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris O'Haver cohaver@infoblox.com
1. Why is this pull request needed and what does it do?
Avoid panic when Corefile reloads.
2. Which issues (if any) are related?
#4880
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?