plugin/metrics: support HTTPS qType in requests count metric label #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a DCO sign-off. You can use |
Signed-off-by: Pavol Lieskovský <pavol.lieskovsky@wandera.com>
|
@SuperQ added, thank you for the info 👍 |
|
happy to add this, but isn't the HTTPS still in draft? Might be prudent to wait until RFC. yeah it still draft: https://datatracker.ietf.org/doc/draft-ietf-dnsop-svcb-https/ |
|
@miekg ah, that's interesting site/fact. Didn't know about it. But as you guys are the owners/maintainers of the repo, the decision is totally up to you :) |
|
[ Quoting ***@***.***> in "Re: [coredns/coredns] plugin/metric..." ]
***@***.*** ah, that's interesting site/fact. Didn't know about it.
On the other hand, iOS has been already using it for about 4 months. We can see
a non-trivial amount (~18%) of HTTPS requests sent to our CoreDNS instance that
faces the internet. So I guess we cannot go wrong with enabling the computation
of it into the metric label.
But as you guys are the owners/maintainers of the repo, the decision is totally
up to you :)
yeah, it's a label value so easily changed and I can see this RR being import, but it
might still see a name change. SVCB might be nice as well (same caveats)
/lgtm
/merge
|
![corbot[bot]](https://avatars.githubusercontent.com/u/21110084?s=60&v=4){kind=small}
jinglina
pushed a commit
to jinglina/coredns
that referenced
this pull request
Dec 23, 2021
…oredns#4934) Automatically submitted. Signed-off-by: jinglinax@163.com <jinglinax@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Since iOS14, apple devices are standardly using the HTTPS query (type 65). It would be beneficial to be able to distinguish the amount of these requests based on the metrics. Therefore I would like to add the HTTPS query type support into the metric labels.
2. Which issues (if any) are related?
none
3. Which documentation changes (if any) need to be made?
none
4. Does this introduce a backward incompatible change or deprecation?
no