Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware/metrics: survive restart #542

Merged
merged 2 commits into from Feb 21, 2017
Merged

middleware/metrics: survive restart #542

merged 2 commits into from Feb 21, 2017

Conversation

miekg
Copy link
Member

@miekg miekg commented Feb 21, 2017

Keep the handler running during restart. Stopping and starting the
handler results in "address in use" - sometimes, meaning the reload
will be flaky. In turn this behavior means any changes to the monitor
stanza are not picked up.

Keep the handler running during restart. Stopping and starting the
handler results in "address in use" - sometimes, meaning the reload
will be flaky. In turn this behavior means any changes to the monitor
stanza are not picked up.
@codecov-io
Copy link

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 76.19%.

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   39.31%   39.31%           
=======================================
  Files         121      121           
  Lines        6069     6069           
=======================================
  Hits         2386     2386           
  Misses       3497     3497           
  Partials      186      186
Impacted Files Coverage Δ
middleware/metrics/setup.go 39.21% <ø> (ø)
middleware/metrics/metrics.go 80% <84.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26242ce...b6e0016. Read the comment docs.

@miekg miekg merged commit 7c59d39 into master Feb 21, 2017
@miekg miekg deleted the metrics-reload branch February 21, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants