remove unused coredns_forward_sockets_open metric #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
yongtang
approved these changes
Jun 13, 2022
dyhkwong
pushed a commit
to dyhkwong/coredns
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
dyhkwong
pushed a commit
to dyhkwong/coredns
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ondřej Benkovský ondrej.benkovsky@jamf.com
1. Why is this pull request needed and what does it do?
removes a metric declaration, this metric is obsolete and is not used anywhere, all usage was removed as part of 2d98d52#diff-2f8a7b4f46ff73fbc67bb790ed42d9d2923ef137d36e12b884cc71928ba67dab
2. Which issues (if any) are related?
no issue, trivial refactoring
3. Which documentation changes (if any) need to be made?
none
4. Does this introduce a backward incompatible change or deprecation?
none