Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The coredns.yaml here does not match the content of the coredns.yaml file in kubenetes #32

Closed
JinsYin opened this issue Dec 11, 2017 · 3 comments

Comments

@JinsYin
Copy link

JinsYin commented Dec 11, 2017

The content of the two files is inconsistent:
https://github.com/coredns/deployment/blob/master/kubernetes/coredns.yaml.sed#L53
https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/coredns.yaml.sed#L62

@fturib
Copy link
Contributor

fturib commented Dec 11, 2017

@rajansandeep : can you have a look here on this diff and the reason ?

@chrisohaver
Copy link
Member

Regarding the lines highlighted - The difference is the presence of the pod CIDR range in the coredns/deployment repo.

The pod CIDR range is dependent on the pod network addon, and is not known at addon install time, hence it is not included in the context of a kubernetes install (e.g. kubeadm init).

The coredns/deployment repo is meant for replacing kubedns with coredns in an existing cluster, at which time the pod CIDR is known. This script allows for one pod CIDR - in reality there could be many pod CIDRs, which would need to be manually added to the configmap.

We've looked into making this configuration automatic/dynamic, which would be ideal. But as of yet, pod CIDRs are not easily determined- for example they are not exposed via the Kubernetes API.

@JinsYin
Copy link
Author

JinsYin commented Dec 13, 2017

@chrisohaver Thx.

@JinsYin JinsYin closed this as completed Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants