Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables on container specs #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edwarddoh
Copy link

It would be great to be able to add environment variables for coredns container.
Our usecase is that we enable role base authentications for the etcd, and to provide a credential information on the etcd plugins for that, we make our coredns configuration block to use environment variables.

our value file is looking like,

...
   plugins:
   - name: etcd
     configBlock: |-
        path /skydns/corp
        endpoint http://10.10.0.123:2379
        credentials {$ETCD_USERNAME} {$ETCD_PASSWORD}
...

To be able to use environment variable that is on the config file, we would like to make this change so that we can pass it through secrets. (one thing we would like to avoid the most is to put the password in the value file..)

Signed-off-by: Ed Doh <ho.doh@bucketplace.net>
Signed-off-by: Ed Doh <ho.doh@bucketplace.net>
@hagaibarel
Copy link
Collaborator

Definitely something we should support, please rebase and bump the chart version by a minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants