Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dive instead of findit to prevent issue #12

Merged
merged 1 commit into from Sep 30, 2011
Merged

Use dive instead of findit to prevent issue #12

merged 1 commit into from Sep 30, 2011

Conversation

pvorb
Copy link
Contributor

@pvorb pvorb commented Sep 30, 2011

There is an issue in findit/seq that causes nide to crash when loading a big project:

massimiliano-giroldi asked me, if dive could do the job. I looked at the code of seq and assumed the error got something to do with the chaining of seq.

So I patched nide. Now

  • it uses dive
  • it's faster
  • issue does not occur anymore

Feel free to test it.

- faster
- [issue](https://github.com/substack/node-seq/issues/17) does not occur (to be
  verified)
coreh added a commit that referenced this pull request Sep 30, 2011
Use dive instead of findit to prevent issue #2 and improve project listing speed.
@coreh coreh merged commit 993c712 into coreh-deprecated:master Sep 30, 2011
@coreh
Copy link
Member

coreh commented Sep 30, 2011

Wow man, thank you so much for this!

I tried it on a directory structure with thousands of files and hundreds of subdirectories, and the issue seems to be gone. Project loading also feels so much faster now. Thanks to you and @massimiliano-giroldi.

@pvorb
Copy link
Contributor Author

pvorb commented Sep 30, 2011

NP. That was fun ;).

Cool project, by the way!

@max-giro
Copy link

nide & dive rocks together!

P.S.:
I think now there is a .nide dir (5.5MB) installed with the module (needs cleaning?).

@coreh
Copy link
Member

coreh commented Sep 30, 2011

oops. But that's strange. It's fixed now, but if you look at my .npmignore
file, .nide is there.

-- Marco Aurlio

On Thu, Sep 29, 2011 at 11:46 PM, massimiliano-giroldi <
reply@reply.github.com>wrote:

nide & dive rocks together!

P.S.:
I think now there is a .nide dir (5.5MB) installed with the module (needs
cleaning?).

Reply to this email directly or view it on GitHub:
#12 (comment)

@max-giro
Copy link

Reinstalei de novo e agora está mesmo sem a 'bagagem' toda : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants