Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Partially add markings, to see what they're like. Should we add the r…
…est?
- Loading branch information
1 parent
694eea5
commit 7df076a
Showing
1 changed file
with
16 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tags should be included for the other MUST criteria.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem with the Ruby guide's approach is that a casual reader only sees "[link]". The casual reader thus won't often be aware that these are specific names (unless they understand URL # anchors).
However, if you're worried about the text flow, that's easily solved by wrapping the [....] in some span and in the CSS making the text raised and smaller. We could also make it an anchor. Then we'd have the smaller text (which I think addresses your text flow concern), we'd have a visible name (which is something I think is important, at least for now while we adjust criteria), and people can jump to places (a nice advantage of HTML named anchors).
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df076a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.