Rename route '/criteria' to '/criteria_stats' #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the route '/criteria', which shows criteria statistics, to '/criteria_stats'. This makes the route consistent with '/project_stats'. It also means we can use '/criteria' to present the criteria themselves (in a format we control and in any locale). Technically this could be considered an API change. However, we only serve this as HTML, not as JSON (yet), so anyone processing this would have had to request the HTML & process it further. In practices, we expect that few people call this, because it simply gives statistics about *just* the criteria while ignoring projects. It's typically more been useful for debugging or giving people a quick summary about the criteria than anything else. Note: After merging, you'll need to send the YAML translations to translation.io, because this renames several keys. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1805 1805
=========================================
Hits 1805 1805
Continue to review full report at Codecov.
|
|
No objections posted, I'm doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the route '/criteria', which shows criteria statistics, to
'/criteria_stats'. This makes the route consistent with '/project_stats'.
It also means we can use '/criteria' to present
the criteria themselves (in a format we control and in any locale).
Technically this could be considered an API change.
However, we only serve this as HTML, not as JSON (yet), so anyone
processing this would have had to request the HTML & process it further.
In practices, we expect that few people call this, because it
simply gives statistics about just the criteria while ignoring projects.
It's typically more been useful for debugging or giving people a
quick summary about the criteria than anything else.
Note: After merging, you'll need to send the YAML translations to
translation.io, because this renames several keys.
Signed-off-by: David A. Wheeler dwheeler@dwheeler.com