This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
Add more rollup config and layout component. closes #51 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 66 66
Lines 1199 1199
Branches 122 122
=======================================
Hits 869 869
Misses 264 264
Partials 66 66
Continue to review full report at Codecov.
|
Closed
2 tasks
added 9 commits
October 13, 2020 09:53
mattvb91
previously approved these changes
Oct 18, 2020
mattvb91
suggested changes
Oct 19, 2020
packages/dev/package.json
Outdated
| @@ -24,7 +24,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@corejam/router": "0.0.5", | |||
| "@stencil/core": "2.0.3", | |||
| "@corejam/run": "^0.0.1", | |||
There was a problem hiding this comment.
Suggested change
| "@corejam/run": "^0.0.1", | |
| "@corejam/run": "0.0.1", |
packages/run/package.json
Outdated
| "generate": "stencil generate" | ||
| }, | ||
| "dependencies": { | ||
| "@corejam/dev": "0.0.5", |
There was a problem hiding this comment.
Suggested change
| "@corejam/dev": "0.0.5", | |
| "@corejam/dev": "0.0.6", |
yarn.lock
Outdated
| @@ -1189,6 +1189,15 @@ | |||
| exec-sh "^0.3.2" | |||
| minimist "^1.2.0" | |||
|
|
|||
| "@corejam/dev@0.0.5": | |||
There was a problem hiding this comment.
Need to regenerate new lock file this shouldn't be here
mattvb91
previously approved these changes
Oct 20, 2020
mattvb91
previously approved these changes
Oct 20, 2020
mattvb91
previously approved these changes
Oct 20, 2020
mattvb91
previously approved these changes
Oct 20, 2020
mattvb91
previously approved these changes
Oct 20, 2020
mattvb91
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.