Updating npm packages dependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ | |||
| "version": "0.11.1", | |||
| "main": "dist/typeahead.bundle.js", | |||
| "dependencies": { | |||
| "jasmine-jquery": "~2.1.1", | |||
There was a problem hiding this comment.
I believe this is an error, since jasmine-jquery is put in devDependencies section.
Will fix
|
Merge? |
|
@CoreSystemDevelopment this branch works. I will clean up and squash the changes so that it's ready to merge. |
… for jquery 1. Also I added a specific line to resolve jquery 1.7 to latest 1.7.2 series, since thats the minimum requirement for this typeahead lib.
jesperronn
changed the title
jesperronn
added a commit
that referenced
this pull request
Oct 25, 2015
Updating npm packages dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this in WIP as I expect to see some errors until all updates are in place.
Eventually, this will update all npm dependencies to most recent versions.
karma-jasminehere, since getting up to Jasmine2 will require more changes.Feel free to open a new pull-request.
I updated