Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more typing #47

Closed
Callek opened this issue Apr 13, 2021 · 1 comment
Closed

Support more typing #47

Callek opened this issue Apr 13, 2021 · 1 comment

Comments

@Callek
Copy link

Callek commented Apr 13, 2021

Addition of the py.typed makes calling immuteabledict() in a typed context warn if we have disallow_untyped_calls defined for mypy...

I suggest the addition of many of the typings that frozendict has be added here: https://github.com/python/typeshed/blob/4b4ced5fa0418f626033d88702833d3185bbf18f/stubs/frozendict/frozendict.pyi#L8
corenting added a commit that referenced this issue May 20, 2021
@corenting
Merge pull request #51 from corenting/fixes
0105ac5 
Add more typing (fix issue #47)
@corenting
Copy link
Owner

Thanks for the report and sorry for the delay of the answer !
I added more types in the 2.0.0 version so I'm closing the issue.

If there are still some problems feel free to open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corenting @Callek