Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings #45

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Add typings #45

merged 1 commit into from
Apr 9, 2021

Conversation

aecay
Copy link
Contributor

@aecay aecay commented Apr 7, 2021

  • Do some dark metaclass magic to support python 3.6 (We can lose this
    if youʼre ok bumping the version dependency of this package to >=3.7,
    since from 3.7 typing.Mapping is a runtime synonym of
    collections.abc.Mapping).
  • Bump the version of poetry. I got weird dependency issues when using
    poetry 1.0.0 to run the tests. Upgrading fixed these, so I didnʼt
    look into them too hard.
  • Add tox.ini to support running the tests locally (gotta make sure 3.6
    still works 😉)
  • Add mypy and tox to the poetry dev-dependencies

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #45 (8a59355) into master (407caff) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8a59355 differs from pull request most recent head c97c464. Consider uploading reports for the commit c97c464 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           46        51    +5     
=========================================
+ Hits            46        51    +5     
Impacted Files Coverage Δ
immutabledict/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407caff...c97c464. Read the comment docs.

@corenting
Copy link
Owner

Thanks you for your contribution 👍 !
It looks good to me. Can you just squash all commits into the first the first one and sign it ?
I will try to integrate this into a release ASAP to fix #41 .

- Do some dark metaclass magic to support python 3.6  (We can lose this
  if youʼre ok bumping the version dependency of this package to >=3.7,
  since from 3.7 `typing.Mapping` is a runtime synonym of
  `collections.abc.Mapping`).
- Bump the version of poetry.  I got weird dependency issues when using
  poetry 1.0.0 to run the tests.  Upgrading fixed these, so I didnʼt
  look into them too hard.
- Add tox.ini to support running the tests locally (gotta make sure 3.6
  still works 😉)
- Add mypy to the poetry dev-dependencies
@aecay
Copy link
Contributor Author

aecay commented Apr 8, 2021

Done 🙂 thanks

@corenting corenting merged commit 365658e into corenting:master Apr 9, 2021
@corenting
Copy link
Owner

Merged :) Thanks again for your PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants