providers/aws: expose instance availability-zone-id as AWS_AVAILABILITY_ZONE_ID #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TY_ZONE_ID ec2 instance metadata exposes the physical id for availability zone. Physical zone ids are useful because they are same across AWS accounts and helpful when trying to decide if instances are actually in the same zone when reconciling that between instances in different accounts. See doc: > https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-categories.html ``` placement/availability-zone-id The static Availability Zone ID in which the instance is launched. The Availability Zone ID is consistent across accounts. However, it might be different from the Availability Zone, which can vary by account. 2020-08-24 ``` This is available in api versions starting 2020-08-24, and afterbun already uses 2021-01-03 [1]. [1]: https://github.com/coreos/afterburn/blob/640ce9790c4f2d56aa75d1e3ad63f8011bec4255/src/providers/aws/mod.rs#L83
|
Known test failure. Merging. |
|
@bgilbert any idea when this rolls out to FCOS ? |
|
No Afterburn release is currently scheduled. Is something blocking on this change? |
|
@abhinavdahiya it should be available in the next https://koji.fedoraproject.org/koji/buildinfo?buildID=1983824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ec2 instance metadata exposes the physical id for availability zone. Physical zone ids are useful
because they are same across AWS accounts and helpful when trying to decide if instances are actually
in the same zone when reconciling that between instances in different accounts.
See doc:
This is available in api versions starting 2020-08-24, and afterbun already uses 2021-01-03 1.