Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoSync field to Options #30

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

tylertreat
Copy link
Contributor

Proposed change to expose NoSync in Options. Hopefully this is a reasonable change. The justification for this is I use a number of libraries which simply expose the Options passed into Open() but not the underlying DB they create. To enable NoSync in these cases, I either have to fork the library or fork bolt.

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@heyitsanthony
Copy link
Contributor

@tylertreat squash to a single commit?

This allows enabling NoSync when you only have access to the Options
passed into Open() and not the returned DB (as is frequently the case
with libraries).
@tylertreat
Copy link
Contributor Author

@heyitsanthony done

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@heyitsanthony heyitsanthony merged commit 337da34 into etcd-io:master Aug 24, 2017
@tylertreat tylertreat deleted the nosync_option branch August 24, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants