-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bios.rs: implement BIOS (grub) #420
Conversation
Skipping CI for Draft Pull Request. |
fcd38ff
to
7e1dbb1
Compare
src/bios.rs
Outdated
} | ||
|
||
fn validate(&self, current: &InstalledContent) -> Result<ValidationResult> { | ||
unreachable!() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed we could probably keep this unimplemented, though it should return an error or so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return Skipped
for BIOS
instead, does that make sense?
[root@cosa-devsh ~]# bootupctl validate
Skipped: BIOS
Validated: EFI
e2db5f2
to
a069059
Compare
7cec5b8
to
cfed9dc
Compare
Will update based on #423 |
4285bed
to
35bb817
Compare
4d51bc7
to
9c27c2e
Compare
Wait, I am testing on
|
Prepare bootupd update directory which will save component metadata files for both components.
This will generate `/usr/lib/bootupd/updates/BIOS.json`, which will have the version and timestamp of `grub2-tools`.
- Add `--device </dev/vda>` option to install BIOS bootloader (grub) - If call function without `--device`, will only install EFI.
This is the same action as `install`
To make CI green and will update in future patch.
c57bfcd
to
d66336b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this!
I hadn't even realized when we started this how complex adding ppc64le would be from the conditional-compilation perspective. Thanks for plowing through all those conditionals.
I think there's some smaller things to clean up here but we can do that post-merge
Thanks so much for your work on this!
This merged a while back but either forgot or never noticed it. Nice work on this @HuijingHei! |
Thanks @jlebon! Also thanks @cgwalters for lots of help! |
As bootupd supports GRUB and ppc64le since 0.2.10, we wil be able to enable it once we enable bootupd support in Silverblue & friends. See: coreos/bootupd#420 See: https://fedoraproject.org/wiki/Changes/FedoraSilverblueBootupd
bootupd: Prepare bootupd update directory for both components
files for both components.
Add bios.rs and implement generate_update_metadata
/usr/lib/bootupd/updates/BIOS.json
, which will have the version and timestamp ofgrub2-tools
bios.rs: implement BIOS (grub) install function
--device </dev/vda>
option to install BIOS bootloader (grub)--device
, will only install EFI.bios.rs: add
run_update
to support bootupctl updateinstall
bios.rs: return
Skipped
when runbootupctl validate
for BIOSppc64: fix build warning
aarch64: fix build warning
Fix #53