Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Update status to reflect current reality #439

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cgwalters
Copy link
Member

README.md Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Should we mention that bootupd doesn't yet perform updates automatically? Folks may assume otherwise if we don't say anything.

@cgwalters
Copy link
Member Author

The FCOS side here is already covered by https://docs.fedoraproject.org/en-US/fedora-coreos/bootloader-updates/ right?

@bgilbert bgilbert disabled auto-merge March 15, 2023 20:29
@bgilbert
Copy link
Contributor

Sure. But the upstream project status should presumably reflect the upstream portion of this.

Disabled auto-merge to avoid this comment creating a race condition.

@cgwalters
Copy link
Member Author

I don't quite understand your comment, please feel free to provide suggested replacement text?

@jlebon
Copy link
Member

jlebon commented Mar 15, 2023

Maybe something like:

As mentioned lower down in the Q&A, there is no method currently to transactionally update the bootloader. As such, bootupd itself does not by default update the bootloader.

?

On that topic, ISTM like bootupd could ship the systemd unit in https://docs.fedoraproject.org/en-US/fedora-coreos/bootloader-updates/ itself as e.g. bootupd-simple-update.service or something? Then it's even easier for users to enable that if they're OK with its semantics.

@bgilbert
Copy link
Contributor

I agree that it'd be good to ship the unit upstream, even if disabled by default.

How about text like this:

bootupd supports updating GRUB and shim for UEFI firmware on x86_64 and aarch64, and GRUB for BIOS firmware on x86_64. The project is deployed in Fedora CoreOS and derivatives, and is also used by the new
bootc install functionality. The bootupd CLI should be considered stable.

bootupd does not yet perform updates in a way that is safe against a power failure at the wrong moment, or against a buggy bootloader update that fails to boot the system. Therefore, by default, bootupd updates the bootloader only when manually instructed to do so.

Came up re coreos/fedora-coreos-tracker#1441

Co-authored-by: Benjamin Gilbert <bgilbert@redhat.com>
@cgwalters
Copy link
Member Author

LGTM, updated to that text.

@cgwalters cgwalters disabled auto-merge March 16, 2023 12:14
@cgwalters
Copy link
Member Author

Nightly Rust failure is rust-lang/rust#109199 (comment)
I don't see a lot of value in testing with nightly here, probably will remove it or at least make it non-gating.

And this is a network flake
/override continuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

Nightly Rust failure is rust-lang/rust#109199 (comment)
I don't see a lot of value in testing with nightly here, probably will remove it or at least make it non-gating.

And this is a network flake
/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit 9ecd615 into coreos:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants