Bump MSRV to 1.66.0 #450
Merged
Bump MSRV to 1.66.0 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what we have elsewhere in coreos/ and I think will be prep for further PRs. Signed-off-by: Colin Walters <walters@verbum.org>
Because this code is right, and what `cargo clippy --fix` wants to do actually breaks compilation. Signed-off-by: Colin Walters <walters@verbum.org>
The unnecessary borrows one always feels like the most churn for the least value, but let's do it. Signed-off-by: Colin Walters <walters@verbum.org>
This clippy lint catches a real bug. Signed-off-by: Colin Walters <walters@verbum.org>
jmarrero
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump MSRV to 1.66.0
This is what we have elsewhere in coreos/ and I think will
be prep for further PRs.
Allow clippy::box_default
Because this code is right, and what
cargo clippy --fixwantsto do actually breaks compilation.
tree-wide: Fix various minor clippy lints
The unnecessary borrows one always feels like the most churn
for the least value, but let's do it.
filetree: Use
.write_all()in testsThis clippy lint catches a real bug.