Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal in non-existent files #528

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

xlejo
Copy link
Contributor

@xlejo xlejo commented Sep 14, 2023

Tested in Fedora Silverblue 38 upgraded from 34 (upgrades from 36 isn't affected).

Fixes #467.

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

Hi @xlejo. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/ok-to-test

@cgwalters
Copy link
Member

Why is Silverblue shipping shim-ia32? That seems like one root bug here. Is it being somehow removed later?

Oh, I think I see; Anaconda may be just ignoring it when copying the bootloader data?

Anyways, I guess this is OK (and thank you so much for working on it!). It's a relatively safe change, but again IMO the real bug lies in the SB config.

@cgwalters
Copy link
Member

/override continuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit f657663 into coreos:main Sep 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error when bootupctl adopt-and-update on Fedora Silverblue 38
2 participants