Add support for root=boot (with EFI) and writing UUID file #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
force-pushed
the
write-uuid-install
branch
2 times, most recently
from
d40ebdc
to
4e7665f
Compare
In FCOS we never tried to support root=boot, but for bootupd to do alongside installs in the general case we have to. There were two things to fix here: - Tweak the EFI "trampoline" to check for both $prefix/grub.cfg and $prefix/boot/grub.cfg - Add support for writing the boot UUID into both places (This avoids higher level tools like bootupd needing to know about how to find the EFI vendor dir) Then the bigger issue here is that we need to support invoking `efibootmgr` to re-synchronize the firmware. This is particularly important in cases like bootc "alongside" installs where we're taking over the target OS.
cgwalters
force-pushed
the
write-uuid-install
branch
from
4e7665f
to
581102a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FCOS we never tried to support root=boot, but for bootupd
to do alongside installs in the general case we have to.
There were two things to fix here:
(This avoids higher level tools like bootupd needing to know
about how to find the EFI vendor dir)
This more fully replicates the logic in coreos-installer.