Implementation of adoption #66
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Working on splitting out some prep work from this PR. |
cgwalters
force-pushed
the
adopt
branch
2 times, most recently
from
90332fc
to
b704d13
Compare
|
Aaand the first actually did eat the |
cgwalters
force-pushed
the
adopt
branch
2 times, most recently
from
18cae2e
to
c7c3c5d
Compare
|
OK now this one just depends on #72 |
|
/retest |
|
OK, lifting WIP on this! |
|
It looks reasonable overall. I've left a few minor comments and a suggestion to maybe tweak the trait slightly. I think this may be missing a |
So far we've supported updating systems that we installed, but we also need to handle updating at least older CoreOS systems. This shares a lot of similarity with `update`; the biggest difference is that we aren't sure which files we should be managing. So given a pending update, we only replace files that exist in that update. Closes: coreos#38
|
Comments addressed! |
EDIT: also our CI runs a cargo fmt check. |
|
@cgwalters some incosistent newlines in |
|
/refresh |
|
/retest |
So far we've supported updating systems that we installed,
but we also need to handle updating at least older CoreOS
systems.
This shares a lot of similarity with
update; the biggestdifference is that we aren't sure which files we should
be managing. So given a pending update, we only replace
files that exist in that update.
Closes: #38