Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
GRUB memory corruption in older Container Linux releases #2400
Container Linux Version
AMD64 booting via BIOS.
GRUB does not corrupt memory.
GRUB corrupts memory. Sometimes this causes boot failures.
Because GRUB is not updated after installation, OS upgrades will not fix the bug. The open question is whether the bug is likely to cause machines to break in the future. We have no evidence that this has happened so far, but we don't really know.
Further characterize the potential impact of the bug on existing systems, and consider adding a
referenced this issue
Apr 10, 2018
Capturing some offline discussion and experimentation:
Binary patching would involve:
This should not be done client side. If we do binary patch, we should build and thoroughly test it with each released version of grub, then the client side should apply the correct update based on either the original install version of a hash of
To find the incorrect and correct values, you can download the binpkg for grub and use the debug symbols in
Another option is to nop-out the call to
It's also worth noting the binkpkg should be the one for the SDK, since we use the SDK's grub, not the board's.
I went ahead and downloaded all the binpkgs from 926 - 1722 (183 releases) and did some analysis:
Things needed before binary patching:
added a commit
May 3, 2018
We're not planning to backport this to the current beta or stable branches; we'll let the change promote through the channels in the usual fashion. GRUB itself is fixed in all three release branches (though the fix is not yet included in a stable release) so there will be no new affected releases. Thus I'll close.