New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker with Go 1.4 #956

Closed
crawford opened this Issue Oct 31, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@crawford
Member

crawford commented Oct 31, 2015

Right now we are building Docker with Go 1.5 while upstream is still using Go 1.4. We cannot expect to have builds that are at least as stable as upstream until we use the same compiler.

@carmstrong

This comment has been minimized.

carmstrong commented Nov 6, 2015

@crawford Is this a prerequisite for getting Docker 1.9 in alpha? Just noticed #1623 and no PR yet for Docker 1.9.

@mischief

This comment has been minimized.

mischief commented Nov 6, 2015

@carmstrong no plans for 1.9 yet.

@carmstrong

This comment has been minimized.

carmstrong commented Nov 6, 2015

no plans for 1.9 yet.

:( We are hoping to get on 1.9 and test it out to hopefully get rid of the ridiculous flocks we had to introduce everywhere to work around the simultaneous layer issue on docker pull. This bit us several times: deis/deis#4590 deis/deis#4609 and is also the reason why we stayed pinned to Docker 1.5 for so long, even though it has a large memory leak.

The Docker team claims it'll be fixed in 1.9 after we complained about it: https://twitter.com/gabrtv/status/652294334960656384

So we're hoping for 1.9. Is there a major reason not to try it on alpha, @mischief? Other than the expected myriad of new issues that we don't yet know about?

@marineam

This comment has been minimized.

marineam commented Nov 6, 2015

@carmstrong the rollback is just for the 835.x.x branch which will be sticking to docker 1.8.x

Getting the 835 branch stabilized is a high priority right now but 1.9 should land in alpha soon, we just haven't had a chance to look at it yet.

@carmstrong

This comment has been minimized.

carmstrong commented Nov 6, 2015

@marineam Understood, thanks for the update.

@mischief

This comment has been minimized.

mischief commented Nov 6, 2015

@mischief mischief closed this Nov 6, 2015

@hosh

This comment has been minimized.

hosh commented Nov 11, 2015

👍 woot! I can come off of the alpha channel now and don't have to use the bind-mount hack :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment