Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Build Docker with Go 1.4 #956

Closed
crawford opened this issue Oct 31, 2015 · 7 comments
Closed

Build Docker with Go 1.4 #956

crawford opened this issue Oct 31, 2015 · 7 comments

Comments

@crawford
Copy link
Contributor

Right now we are building Docker with Go 1.5 while upstream is still using Go 1.4. We cannot expect to have builds that are at least as stable as upstream until we use the same compiler.

@carmstrong
Copy link

@crawford Is this a prerequisite for getting Docker 1.9 in alpha? Just noticed #1623 and no PR yet for Docker 1.9.

@mischief
Copy link

mischief commented Nov 6, 2015

@carmstrong no plans for 1.9 yet.

@carmstrong
Copy link

no plans for 1.9 yet.

:( We are hoping to get on 1.9 and test it out to hopefully get rid of the ridiculous flocks we had to introduce everywhere to work around the simultaneous layer issue on docker pull. This bit us several times: deis/deis#4590 deis/deis#4609 and is also the reason why we stayed pinned to Docker 1.5 for so long, even though it has a large memory leak.

The Docker team claims it'll be fixed in 1.9 after we complained about it: https://twitter.com/gabrtv/status/652294334960656384

So we're hoping for 1.9. Is there a major reason not to try it on alpha, @mischief? Other than the expected myriad of new issues that we don't yet know about?

@marineam
Copy link

marineam commented Nov 6, 2015

@carmstrong the rollback is just for the 835.x.x branch which will be sticking to docker 1.8.x

Getting the 835 branch stabilized is a high priority right now but 1.9 should land in alpha soon, we just haven't had a chance to look at it yet.

@carmstrong
Copy link

@marineam Understood, thanks for the update.

@mischief
Copy link

mischief commented Nov 6, 2015

fixed by coreos/coreos-overlay#1623

@mischief mischief closed this as completed Nov 6, 2015
@hosh
Copy link

hosh commented Nov 11, 2015

👍 woot! I can come off of the alpha channel now and don't have to use the bind-mount hack :-D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants